fix: fix network switch on dapp

[salimtb]

Description

Related issues

Fixes: #30149

Manual testing steps

1. Go to dapp ( sushi swap for instance )
2. switch network
3. check the list of tokens

Screenshots/Recordings

Before

After

fixed.mov

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [0e1dcb8]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1900 ± 139 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	703	2769	1814	367	176
		domContentLoaded	1597	2690	1865	285	137
		load	1605	2745	1900	289	139
		domInteractive	25	122	47	26	12
		backgroundConnect	9	77	31	20	9
		firstReactRender	16	73	35	21	10
		getState	5	63	26	22	10
		initialActions	0	1	0	0	0
		loadScripts	1151	2128	1372	247	119
		setupStore	8	77	17	18	9
		uiStartup	1872	2965	2181	301	145

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 303 Bytes (0.01%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [1ab8ebe]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1687 ± 52 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1511	2008	1688	121	58
		domContentLoaded	1495	1935	1656	114	55
		load	1517	1948	1687	108	52
		domInteractive	24	172	42	32	15
		backgroundConnect	13	79	33	21	10
		firstReactRender	17	176	41	38	18
		getState	7	57	21	19	9
		initialActions	0	48	3	10	5
		loadScripts	1058	1478	1206	104	50
		setupStore	6	59	17	17	8
		uiStartup	1708	2353	1965	154	74

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 303 Bytes (0.01%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[Prithpal-Sooriya]

Hmmm what is this condition doing here?

Object.keys(tokenNetworkFilter).length === 1

this related to portfolio view (you are only viewing tokens from 1 network, so not in portfolio view).

this.preferencesController.setPreference(... {[chainId]: true})

this is to swap the tokens I'm interested in to the newly selected network?

[Prithpal-Sooriya]

So if I am in portfolio view, and I switch networks from a dapp, I stay in portfolio view?
But what if it is a not popular network?

[salimtb]

what we're doing is checking if the chainId is defined and whether the tokenNetworkFilter corresponds to the current network—something like { '0x1': true }. Then, if we switch from Ethereum to BNB in the dapp, we would update this to { '0x38': true }.

[Prithpal-Sooriya]

Yep nice. I've ran the branch and validated the fix.

This is a little confusing though, in the future do you think it would be worth moving this (token filter list) logic in a shared location/module/utilities? We can discuss this later.

[metamaskbot]

Builds ready [0bb5bc9]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1622 ± 48 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	317	1898	1557	302	145
		domContentLoaded	1448	1867	1606	99	48
		load	1456	1881	1622	101	48
		domInteractive	23	75	34	16	8
		backgroundConnect	8	50	21	15	7
		firstReactRender	14	72	34	23	11
		getState	4	59	11	14	7
		initialActions	0	1	0	0	0
		loadScripts	994	1381	1156	89	43
		setupStore	7	69	14	17	8
		uiStartup	1663	2362	1865	151	72

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 303 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)