feat: Add e2e tests of speeding up and cancelling transactions #30212

pedronfigueiredo · 2025-02-07T18:41:39Z

Description

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4141

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-02-07T18:41:53Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-02-07T19:15:17Z

Builds ready [98895bd]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1827 ± 77 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	315	2248	1750	367	176
		domContentLoaded	1542	2185	1798	163	78
		load	1547	2205	1827	160	77
		domInteractive	27	103	41	21	10
		backgroundConnect	9	77	32	23	11
		firstReactRender	18	103	55	29	14
		getState	4	61	14	15	7
		initialActions	0	76	4	17	8
		loadScripts	1075	1604	1308	136	65
		setupStore	7	65	17	17	8
		uiStartup	1745	2601	2136	243	117

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-02-07T19:56:39Z

Builds ready [ac4a3ca]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1705 ± 80 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	421	1982	1550	383	184
		domContentLoaded	1505	2201	1672	165	79
		load	1514	2208	1705	166	80
		domInteractive	23	103	37	19	9
		backgroundConnect	9	218	41	44	21
		firstReactRender	15	117	33	27	13
		getState	4	76	16	21	10
		initialActions	0	1	0	0	0
		loadScripts	985	1582	1190	128	61
		setupStore	6	64	16	18	9
		uiStartup	1752	2997	1988	290	139

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

seaona · 2025-02-10T13:32:04Z

test/e2e/tests/confirmations/transactions/speed-up-and-cancel-confirmations.spec.ts

+
+          // Click speed up button and confirm
+          await driver.clickElement('[data-testid="speedup-button"]');
+          await driver.clickElement({ text: 'Submit', tag: 'button' });


do you think we could use page objects in both specs? 🙏

metamaskbot · 2025-02-11T11:06:20Z

Builds ready [92c5f75]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1690 ± 53 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1497	1921	1699	118	57
		domContentLoaded	1456	1897	1666	117	56
		load	1498	1906	1690	111	53
		domInteractive	20	102	42	22	11
		backgroundConnect	9	70	26	20	10
		firstReactRender	15	84	39	25	12
		getState	4	56	17	16	8
		initialActions	0	1	0	0	0
		loadScripts	1024	1400	1195	100	48
		setupStore	7	65	18	18	9
		uiStartup	1649	2534	1965	197	95

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

seaona · 2025-02-11T13:46:54Z

test/e2e/page-objects/pages/transaction-list-page.ts

+  async goToActivityTab() {
+    await this.driver.clickElement(
+      '[data-testid="account-overview__activity-tab"]',
+    );


We already have a class for the Home page which goes to activity list:

https://github.com/MetaMask/metamask-extension/blob/main/test/e2e/page-objects/pages/home/homepage.ts#L100

seaona · 2025-02-11T13:47:48Z

test/e2e/page-objects/pages/transaction-list-page.ts

+
+  async cancelTransaction() {
+    await this.driver.clickElement({ text: 'Cancel', tag: 'button' });
+    await this.driver.clickElement({ text: 'Submit', tag: 'button' });


we already have a class for the ActivityList page where we can use existing methods, and extend whatever is needed there, instead of creating a new page 🙏

https://github.com/MetaMask/metamask-extension/blob/main/test/e2e/page-objects/pages/home/activity-list.ts

metamaskbot · 2025-02-11T14:13:01Z

Builds ready [bec9e7f]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1728 ± 45 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	357	1891	1657	313	150
		domContentLoaded	1518	1874	1696	94	45
		load	1529	1888	1728	94	45
		domInteractive	24	123	42	24	11
		backgroundConnect	8	102	39	28	13
		firstReactRender	17	81	44	24	12
		getState	5	86	15	19	9
		initialActions	0	1	0	0	0
		loadScripts	1099	1393	1237	77	37
		setupStore	6	69	18	18	9
		uiStartup	1710	2548	1989	186	89

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-02-11T17:29:18Z

Builds ready [5b27525]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1773 ± 47 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1577	1934	1776	98	47
		domContentLoaded	1567	1928	1751	91	44
		load	1578	1934	1773	98	47
		domInteractive	25	88	33	14	7
		backgroundConnect	10	72	28	19	9
		firstReactRender	17	74	35	23	11
		getState	5	58	16	17	8
		initialActions	0	1	0	0	0
		loadScripts	1124	1474	1280	87	42
		setupStore	7	62	24	21	10
		uiStartup	1823	2261	2031	108	52

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

seaona

awesome 🔥 thank you for the changes 🙏

pedronfigueiredo added the team-confirmations Push issues to confirmations team label Feb 7, 2025

pedronfigueiredo self-assigned this Feb 7, 2025

pedronfigueiredo force-pushed the pnf/4141 branch from 98895bd to ac4a3ca Compare February 7, 2025 19:20

seaona reviewed Feb 10, 2025

View reviewed changes

jpuri previously approved these changes Feb 11, 2025

View reviewed changes

OGPoyraz previously approved these changes Feb 11, 2025

View reviewed changes

pedronfigueiredo added this pull request to the merge queue Feb 11, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 11, 2025

pedronfigueiredo added this pull request to the merge queue Feb 11, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 11, 2025

pedronfigueiredo added this pull request to the merge queue Feb 11, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 11, 2025

pedronfigueiredo dismissed stale reviews from OGPoyraz and jpuri via bec9e7f February 11, 2025 13:34

pedronfigueiredo force-pushed the pnf/4141 branch from 92c5f75 to bec9e7f Compare February 11, 2025 13:34

seaona requested changes Feb 11, 2025

View reviewed changes

OGPoyraz previously approved these changes Feb 11, 2025

View reviewed changes

pedronfigueiredo dismissed OGPoyraz’s stale review via 99f235e February 11, 2025 14:18

pedronfigueiredo force-pushed the pnf/4141 branch from bec9e7f to 99f235e Compare February 11, 2025 14:18

jpuri previously approved these changes Feb 11, 2025

View reviewed changes

pedronfigueiredo dismissed jpuri’s stale review via aea6918 February 11, 2025 14:45

pedronfigueiredo force-pushed the pnf/4141 branch 2 times, most recently from aea6918 to c27822d Compare February 11, 2025 16:36

pedronfigueiredo added 2 commits February 11, 2025 16:50

feat: Add e2e tests of speeding up and cancelling transactions

e7162a7

Migrate to the POM

69dd745

fix: POM migration

5b27525

pedronfigueiredo force-pushed the pnf/4141 branch from c27822d to 5b27525 Compare February 11, 2025 16:50

seaona approved these changes Feb 12, 2025

View reviewed changes

pnarayanaswamy approved these changes Feb 12, 2025

View reviewed changes

pedronfigueiredo added this pull request to the merge queue Feb 12, 2025

Merged via the queue into main with commit 8005275 Feb 12, 2025
72 checks passed

pedronfigueiredo deleted the pnf/4141 branch February 12, 2025 10:02

github-actions bot locked and limited conversation to collaborators Feb 12, 2025

metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Feb 12, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add e2e tests of speeding up and cancelling transactions #30212

feat: Add e2e tests of speeding up and cancelling transactions #30212

pedronfigueiredo commented Feb 7, 2025 •

edited by github-actions bot

Loading

github-actions bot commented Feb 7, 2025

metamaskbot commented Feb 7, 2025

metamaskbot commented Feb 7, 2025

seaona Feb 10, 2025

metamaskbot commented Feb 11, 2025

seaona Feb 11, 2025

seaona Feb 11, 2025 •

edited

Loading

metamaskbot commented Feb 11, 2025

metamaskbot commented Feb 11, 2025

seaona left a comment

feat: Add e2e tests of speeding up and cancelling transactions #30212

feat: Add e2e tests of speeding up and cancelling transactions #30212

Conversation

pedronfigueiredo commented Feb 7, 2025 • edited by github-actions bot Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Feb 7, 2025

metamaskbot commented Feb 7, 2025

metamaskbot commented Feb 7, 2025

seaona Feb 10, 2025

Choose a reason for hiding this comment

metamaskbot commented Feb 11, 2025

seaona Feb 11, 2025

Choose a reason for hiding this comment

seaona Feb 11, 2025 • edited Loading

Choose a reason for hiding this comment

metamaskbot commented Feb 11, 2025

metamaskbot commented Feb 11, 2025

seaona left a comment

Choose a reason for hiding this comment

pedronfigueiredo commented Feb 7, 2025 •

edited by github-actions bot

Loading

seaona Feb 11, 2025 •

edited

Loading