-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrading design tokens from v4.2.0
to 5.0.0
and removing unneeded css
#30216
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
@@ -300,7 +300,7 @@ | |||
"@metamask/browser-passworder": "^4.3.0", | |||
"@metamask/contract-metadata": "^2.5.0", | |||
"@metamask/controller-utils": "^11.4.0", | |||
"@metamask/design-tokens": "^4.2.0", | |||
"@metamask/design-tokens": "^5.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading design tokens to v5
@@ -3,7 +3,6 @@ | |||
*/ | |||
@import './reset.scss'; | |||
@import './utilities/fonts.scss'; | |||
@import './utilities/pending-colors.scss'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing deleted file import
:root { | ||
--color-error-muted-hover: #d738473f; // This is var(--brand-colors-red-red100) but with 20% opacity | ||
--color-error-muted-pressed: #d738474c; // This is var(--brand-colors-red-red200) but with 30% opacity | ||
} | ||
|
||
|
||
/** | ||
* Dark Theme Colors | ||
* Colors for dark theme | ||
*/ | ||
|
||
[data-theme='dark'] { | ||
--color-error-muted-hover: #d738473f; // This is var(--brand-colors-red-red100) but with 20% opacity | ||
--color-error-muted-pressed: #d738474c; // This is var(--brand-colors-red-red200) but with 30% opacity | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These colors were included in the design tokens v5
Builds ready [7524732]
Page Load Metrics (1537 ± 61 ms)
Bundle size diffs
|
Description
This PR updates the @metamask/design-tokens package from
v4.2.0
tov5.0.0
and removes thepending-colors.scss
file. The error state colors (error-muted-hover
anderror-muted-pressed
) that were previously defined locally are now available in the design tokens package.The major version bump (
v5.0.0
) of design-tokens is due to breaking changes in TypeScript types, which don't affect the MetaMask extension since we don't use those type imports directly.Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4171
Manual testing steps
Screenshots/Recordings
No visual changes expected as this is replacing locally defined colors with the same colors from the design system package
Before
before.mov
After
after.mov
Pre-merge author checklist
Pre-merge reviewer checklist