-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cp-12.12.0 CAIP-25 Permission Migration when eth_accounts has not been granted #30218
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [cbc47b7]
Page Load Metrics (1600 ± 65 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Builds ready [b7860fb]
Page Load Metrics (1975 ± 120 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Description
Fixes a bug in the CAIP-25 Permission migration file that incorrectly aborting the migration if there were any subjects without eth_accounts.
Related issues
See: #27847
Manual testing steps
git checkout Version-v12.11.0
,yarn
,yarn start
await chrome.storage.local.get()
to get local stateyarn
,yarn start
await chrome.storage.local.get()
to get local stateendowment:caip25
permission nowScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist