Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update main.yml #30220

Open
wants to merge 1 commit into
base: sip-26
Choose a base branch
from
Open

Update main.yml #30220

wants to merge 1 commit into from

Conversation

Setland34
Copy link

@Setland34 Setland34 commented Feb 8, 2025

Based on the recent file changes, here is the corrected version of your workflow file with the updated version references:

name: Main

on:
  push:
    branches:
      - main
      - master
      - Version-v*
  pull_request:
    types:
      - opened
      - reopened
      - synchronize
  merge_group:

jobs:
  lint-workflows:
    name: Lint workflows
    uses: metamask/github-tools/.github/workflows/lint-workflows.yml@latest

  test-lint-shellcheck:
    name: Test lint shellcheck
    uses: ./.github/workflows/test-lint-shellcheck.yml

  test-lint:
    name: Test lint
    uses: ./.github/workflows/test-lint.yml

  test-circular-deps:
    name: Test circular deps
    uses: ./.github/workflows/test-circular-deps.yml

  test-lint-changelog:
    name: Test lint changelog
    uses: ./.github/workflows/test-lint-changelog.yml

  test-lint-lockfile:
    name: Test lint lockfile
    uses: ./.github/workflows/test-lint-lockfile.yml

  test-deps-audit:
    name: Test deps audit
    uses: ./.github/workflows/test-deps-audit.yml

  test-yarn-dedupe:
    name: Test yarn dedupe
    uses: ./.github/workflows/test-yarn-dedupe.yml

  test-deps-depcheck:
    name: Test deps depcheck
    uses: ./.github/workflows/test-deps-depcheck.yml

  test-storybook:
    name: Test storybook
    uses: ./.github/workflows/test-storybook.yml

  validate-lavamoat-allow-scripts:
    name: Validate lavamoat allow scripts
    uses: ./.github/workflows/validate-lavamoat-allow-scripts.yml

  validate-lavamoat-policy-build:
    name: Validate lavamoat policy build
    uses: ./.github/workflows/validate-lavamoat-policy-build.yml

  validate-lavamoat-policy-webapp:
    name: Validate lavamoat policy webapp
    uses: ./.github/workflows/validate-lavamoat-policy-webapp.yml

  run-tests:
    name: Run tests
    uses: ./.github/workflows/run-tests.yml

  wait-for-circleci-workflow-status:
    name: Wait for CircleCI workflow status
    uses: ./.github/workflows/wait-for-circleci-workflow-status.yml

  runway:
    name: Runway
    # For a `pull_request` event, the branch is `github.head_ref`.
    # For a `push` event, the branch is `github.ref_name`.
    if: ${{ startsWith(github.head_ref || github.ref_name, 'Version-v') }}
    needs:
      - wait-for-circleci-workflow-status
    uses: ./.github/workflows/runway.yml

  build-storybook:
    name: Build storybook
    uses: ./.github/workflows/build-storybook.yml
    secrets:
      STORYBOOK_TOKEN: ${{ secrets.STORYBOOK_TOKEN }}
    permissions:
      contents: read
      # id-token permission is required for uploading to s3
      id-token: write

  build-beta:
    name: Build beta
    uses: ./.github/workflows/build-beta.yml
    permissions:
      contents: read
      # id-token permission is required for uploading to s3
      id-token: write

  publish-prerelease:
    name: Publish prerelease
    if: ${{ github.event_name == 'pull_request' }}
    needs:
      - wait-for-circleci-workflow-status
      - build-storybook
      - build-beta
    uses: ./.github/workflows/publish-prerelease.yml
    secrets:
      PR_COMMENT_TOKEN: ${{ secrets.PR_COMMENT_TOKEN }}

  all-jobs-completed:
    name: All jobs completed
    runs-on: ubuntu-latest
    needs:
      - lint-workflows
      - test-lint-shellcheck
      - test-lint
      - test-lint-changelog
      - test-lint-lockfile
      - test-yarn-dedupe
      - test-deps-depcheck
      - test-storybook
      - validate-lavamoat-allow-scripts
      - validate-lavamoat-policy-build
      - validate-lavamoat-policy-webapp
      - run-tests
      - wait-for-circleci-workflow-status
      - build-storybook
      - build-beta
    outputs:
      PASSED: ${{ steps.set-output.outputs.PASSED }}
    steps:
      - name: Set PASSED output
        id: set-output
        run: echo "PASSED=true" >> "$GITHUB_OUTPUT"

  all-jobs-pass:
    name: All jobs pass
    if: ${{ always() }}
    runs-on: ubuntu-latest
    needs:
      - all-jobs-completed
    steps:
      - name: Check that all jobs have passed
        run: |
          passed="${{ needs.all-jobs-completed.outputs.PASSED }}"
          if [[ $passed != "true" ]]; then
            exit 1
          fi

  log-merge-group-failure:
    name: Log merge group failure
    # Only run this job if the merge group event fails, skip on forks
    if: ${{ github.event_name == 'merge_group' && failure() && !github.event.repository.fork }}
    needs:
      - all-jobs-pass
    uses: metamask/github-tools/.github/workflows/log-merge-group-failure.yml@latest
    secrets:
      GOOGLE_APPLICATION_CREDENTIALS: ${{ secrets.GOOGLE_APPLICATION_CREDENTIALS }}
      GOOGLE_SERVICE_ACCOUNT: ${{ secrets.GOOGLE_SERVICE_ACCOUNT }}
      SPREADSHEET_ID: ${{ secrets.GOOGLE_MERGE_QUEUE_SPREADSHEET_ID }}
      SHEET_NAME: ${{ secrets.GOOGLE_MERGE_QUEUE_SHEET_NAME }}

Please update the version tags to the latest versions as specified in the MetaMask GitHub Tools repository.

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Based on the recent file changes, here is the corrected version of your workflow file with the updated version references:

```yaml
name: Main

on:
  push:
    branches:
      - main
      - master
      - Version-v*
  pull_request:
    types:
      - opened
      - reopened
      - synchronize
  merge_group:

jobs:
  lint-workflows:
    name: Lint workflows
    uses: metamask/github-tools/.github/workflows/lint-workflows.yml@latest

  test-lint-shellcheck:
    name: Test lint shellcheck
    uses: ./.github/workflows/test-lint-shellcheck.yml

  test-lint:
    name: Test lint
    uses: ./.github/workflows/test-lint.yml

  test-circular-deps:
    name: Test circular deps
    uses: ./.github/workflows/test-circular-deps.yml

  test-lint-changelog:
    name: Test lint changelog
    uses: ./.github/workflows/test-lint-changelog.yml

  test-lint-lockfile:
    name: Test lint lockfile
    uses: ./.github/workflows/test-lint-lockfile.yml

  test-deps-audit:
    name: Test deps audit
    uses: ./.github/workflows/test-deps-audit.yml

  test-yarn-dedupe:
    name: Test yarn dedupe
    uses: ./.github/workflows/test-yarn-dedupe.yml

  test-deps-depcheck:
    name: Test deps depcheck
    uses: ./.github/workflows/test-deps-depcheck.yml

  test-storybook:
    name: Test storybook
    uses: ./.github/workflows/test-storybook.yml

  validate-lavamoat-allow-scripts:
    name: Validate lavamoat allow scripts
    uses: ./.github/workflows/validate-lavamoat-allow-scripts.yml

  validate-lavamoat-policy-build:
    name: Validate lavamoat policy build
    uses: ./.github/workflows/validate-lavamoat-policy-build.yml

  validate-lavamoat-policy-webapp:
    name: Validate lavamoat policy webapp
    uses: ./.github/workflows/validate-lavamoat-policy-webapp.yml

  run-tests:
    name: Run tests
    uses: ./.github/workflows/run-tests.yml

  wait-for-circleci-workflow-status:
    name: Wait for CircleCI workflow status
    uses: ./.github/workflows/wait-for-circleci-workflow-status.yml

  runway:
    name: Runway
    # For a `pull_request` event, the branch is `github.head_ref`.
    # For a `push` event, the branch is `github.ref_name`.
    if: ${{ startsWith(github.head_ref || github.ref_name, 'Version-v') }}
    needs:
      - wait-for-circleci-workflow-status
    uses: ./.github/workflows/runway.yml

  build-storybook:
    name: Build storybook
    uses: ./.github/workflows/build-storybook.yml
    secrets:
      STORYBOOK_TOKEN: ${{ secrets.STORYBOOK_TOKEN }}
    permissions:
      contents: read
      # id-token permission is required for uploading to s3
      id-token: write

  build-beta:
    name: Build beta
    uses: ./.github/workflows/build-beta.yml
    permissions:
      contents: read
      # id-token permission is required for uploading to s3
      id-token: write

  publish-prerelease:
    name: Publish prerelease
    if: ${{ github.event_name == 'pull_request' }}
    needs:
      - wait-for-circleci-workflow-status
      - build-storybook
      - build-beta
    uses: ./.github/workflows/publish-prerelease.yml
    secrets:
      PR_COMMENT_TOKEN: ${{ secrets.PR_COMMENT_TOKEN }}

  all-jobs-completed:
    name: All jobs completed
    runs-on: ubuntu-latest
    needs:
      - lint-workflows
      - test-lint-shellcheck
      - test-lint
      - test-lint-changelog
      - test-lint-lockfile
      - test-yarn-dedupe
      - test-deps-depcheck
      - test-storybook
      - validate-lavamoat-allow-scripts
      - validate-lavamoat-policy-build
      - validate-lavamoat-policy-webapp
      - run-tests
      - wait-for-circleci-workflow-status
      - build-storybook
      - build-beta
    outputs:
      PASSED: ${{ steps.set-output.outputs.PASSED }}
    steps:
      - name: Set PASSED output
        id: set-output
        run: echo "PASSED=true" >> "$GITHUB_OUTPUT"

  all-jobs-pass:
    name: All jobs pass
    if: ${{ always() }}
    runs-on: ubuntu-latest
    needs:
      - all-jobs-completed
    steps:
      - name: Check that all jobs have passed
        run: |
          passed="${{ needs.all-jobs-completed.outputs.PASSED }}"
          if [[ $passed != "true" ]]; then
            exit 1
          fi

  log-merge-group-failure:
    name: Log merge group failure
    # Only run this job if the merge group event fails, skip on forks
    if: ${{ github.event_name == 'merge_group' && failure() && !github.event.repository.fork }}
    needs:
      - all-jobs-pass
    uses: metamask/github-tools/.github/workflows/log-merge-group-failure.yml@latest
    secrets:
      GOOGLE_APPLICATION_CREDENTIALS: ${{ secrets.GOOGLE_APPLICATION_CREDENTIALS }}
      GOOGLE_SERVICE_ACCOUNT: ${{ secrets.GOOGLE_SERVICE_ACCOUNT }}
      SPREADSHEET_ID: ${{ secrets.GOOGLE_MERGE_QUEUE_SPREADSHEET_ID }}
      SHEET_NAME: ${{ secrets.GOOGLE_MERGE_QUEUE_SHEET_NAME }}
```

Please update the version tags to the latest versions as specified in the MetaMask GitHub Tools repository.
Copy link
Contributor

github-actions bot commented Feb 8, 2025

CLA Signature Action:

Thank you for your submission, we really appreciate it. We ask that you read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:

I have read the CLA Document and I hereby sign the CLA

By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository.

0 out of 1 committers have signed the CLA.
@Setland34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants