refactor: token-cell and token-list-item
#30222
Closed
+549
−347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
gambinish
commented
Feb 8, 2025
Comment on lines
36
to
111
| const useTokenDisplayInfo = ({ | ||
| token, | ||
| }: UseTokenDisplayInfoProps): TokenDisplayInfo => { | ||
| const t = useI18nContext(); | ||
| const isEvm = useSelector(getMultichainIsEvm); | ||
| const tokenList = useSelector(getTokenList); | ||
| const erc20TokensByChain = useSelector(selectERC20TokensByChain); | ||
| const shouldShowFiat = useShouldShowFiat(); // TODO: break out currency formatter into a useFormattedFiatHook (chain agnostic) | ||
| const currentCurrency = useSelector(getCurrentCurrency); | ||
| const locale = useSelector(getIntlLocale); | ||
| const tokenChainImage = getImageForChainId(token?.chainId); | ||
|
|
||
| const secondaryThreshold = 0.01; | ||
|
|
||
| // Format for fiat balance with currency style | ||
| const secondary = shouldShowFiat | ||
| ? formatWithThreshold(token.tokenFiatAmount, secondaryThreshold, locale, { | ||
| style: 'currency', | ||
| currency: currentCurrency.toUpperCase(), | ||
| }) | ||
| : undefined; | ||
|
|
||
| const primary = formatAmount( | ||
| locale, | ||
| new BigNumber(Number(token.string) || '0', 10), | ||
| ); | ||
|
|
||
| const isEvmMainnet = | ||
| token.chainId && isEvm ? isChainIdMainnet(token.chainId) : false; | ||
|
|
||
| const isStakeable = isEvmMainnet && isEvm && token.isNative; | ||
|
|
||
| if (isEvm) { | ||
| const tokenData = Object.values(tokenList).find( | ||
| (tokenToFind) => | ||
| isEqualCaseInsensitive(tokenToFind.symbol, token.symbol) && | ||
| isEqualCaseInsensitive(tokenToFind.address, token.address), | ||
| ); | ||
|
|
||
| const title = | ||
| tokenData?.name || | ||
| (token.chainId === '0x1' && token.symbol === 'ETH' | ||
| ? 'Ethereum' | ||
| : token.chainId && | ||
| erc20TokensByChain?.[token.chainId]?.data?.[ | ||
| token.address.toLowerCase() | ||
| ]?.name) || | ||
| token.symbol; | ||
|
|
||
| const tokenImage = | ||
| tokenData?.iconUrl || | ||
| (token.chainId && | ||
| erc20TokensByChain?.[token.chainId]?.data?.[token.address.toLowerCase()] | ||
| ?.iconUrl) || | ||
| token.image; | ||
|
|
||
| return { | ||
| title, | ||
| tokenImage, | ||
| primary, | ||
| secondary, | ||
| isStakeable, | ||
| tokenChainImage, | ||
| }; | ||
| } else { | ||
| // TODO non-evm assets | ||
| return { | ||
| title: '', | ||
| tokenImage: '', | ||
| primary, | ||
| secondary, | ||
| isStakeable, | ||
| tokenChainImage, | ||
| }; | ||
| } | ||
| }; |
There was a problem hiding this comment.
This desperately needs to be simplified
gambinish
changed the title
token-cell and token-list-item
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist