Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: MetaMask links #30226

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Fix: MetaMask links #30226

wants to merge 4 commits into from

Conversation

hmalik88
Copy link
Contributor

@hmalik88 hmalik88 commented Feb 9, 2025

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:

  1. What is the reason for the change? MetaMask links are broken in Snap dialogs.
  2. What is the improvement/solution? Since it's not possible to programmatically open the extension, it isn't possible to navigate from a Snap dialog to a MetaMask route (home screen or Snap page). The proposed solution is to cancel the dialog and just open the MetaMask link in a new tab if we're in a "notification" environment.

Related issues

Fixes: #29978

Manual testing steps

  1. Build the extension with this branch
  2. Trigger a snap dialog with a MetaMask link
  3. Visit the link and observe that it opens in a new tab.

Screenshots/Recordings

After

Screen.Recording.2025-02-08.at.8.54.36.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Feb 9, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-snaps-platform Snaps Platform team label Feb 9, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [6743ed3]
Page Load Metrics (1602 ± 48 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14151847160310752
domContentLoaded1407179715729947
load14171840160210148
domInteractive246732126
backgroundConnect105830189
firstReactRender1592312512
getState4549115
initialActions01000
loadScripts979137511369445
setupStore65717189
uiStartup16432216183713364
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 434 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [f101432]
Page Load Metrics (1716 ± 102 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint39921921629336161
domContentLoaded145921961691209100
load146822071716213102
domInteractive24150412914
backgroundConnect982312311
firstReactRender1696432613
getState55413147
initialActions01000
loadScripts10311648122816780
setupStore76519189
uiStartup167625061970239115
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 602 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix MetaMask links not working from within Snaps UI
2 participants