[Refactor] Camera Property Metadata #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…() instead of c&p strings
…o property of the same name
|
All camera implementations are converted to the new system :) |
…on (not needed since settings apply immediatly)
|
What about this PR - is it still a topic and will it be reviewed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49
Only RealSense2 was converted to the new Attributes.
Attributes are still converted to ParamDesc<> internally to keep compatibility with
MetriCam2.Controls.After a first review and feedback the remaining camera implementations need to be converted to the new system. This needs to happen before merging.
At some point I would love to move all the ParamDesc<> stuff and the translation layer over to
MetriCam2.Controlsand declare it deprecated.