Update docker readme to also build with GUI #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closed because not up to date with main |
|
Thanks for the PR. I'm piggybacking off of this README update to also incorporate the build type fixes from d78b422 |
That's no problem -- I don't mind having a slightly tangled history here. Going to merge regardlessly. |
fnysalehi
pushed a commit
to fnysalehi/instant-ngp-rendering
that referenced
this pull request
May 14, 2024
…-GUI Update docker readme to also build with GUI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docker can also be built with GUI support if sharing the X11. Modified instructions to explain how to do it.