-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ladybird.rb
formula
#40
base: main
Are you sure you want to change the base?
Conversation
fcec496
to
bbaa1e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell Ladybird doesn't provide any precompiled builds yet so this would have to be a formula rather than a cask. Spent a few minutes on it but it looks like it'll be fairly complicated to build.
Worth considering whether it's appropriate for a brew formula at this time LadybirdBrowser/ladybird#25 (comment)
Also seems like you've got some extraneous commits in here.
Please do the following:
- Move it to the formulas folder
- Fix the style issues (tabs instead of spaces, wrong indentation)
- Make it actually build (seemingly will need more dependencies and possibly more build commands. not 100% sure what changes will be required. I messed with it for a while and couldn't get it to build)
- You may want to get rid of the extraneous commits that change
README.md
in unrelated ways
This was a typo, meant to close a different PR. |
|
We'd appreciate any outside help to build Ladybird 🤍 |
For reference, the Nix package contains some build steps. |
df26730
to
b895061
Compare
There's been some progress and got rid of some of the errors when building it. Currently fails with:
Ladybird uses Skia for rendering SVG and 2D canvas. Right now google/skia is not available in homebrew-core, so we might need to package it to build Ladybird. |
6039db7
to
41e5f7c
Compare
Decided to take a different approach using the steps from BuildInstructionsLadybird.md, namely: brew install autoconf autoconf-archive automake ccache cmake ffmpeg nasm ninja pkg-config llvm
CC=$(brew --prefix llvm)/bin/clang CXX=$(brew --prefix llvm)/bin/clang++ ./Meta/ladybird.sh build |
Signed-off-by: risc <[email protected]>
Signed-off-by: risc <[email protected]>
Ladybird seems to be building, but we need to move the resulting |
I installed the current
The directory |
Hey @tostr7191 thx for trying this out! Wasn't advancing with it personally, so I assigned it to @0risc. We'd love any help to push this forward! |
Any PRs to build this welcome!