-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixops: fix dependencies #147049
nixops: fix dependencies #147049
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
03525cf
to
07a8ac8
Compare
07a8ac8
to
b506c9d
Compare
b506c9d
to
192bbb9
Compare
@ofborg build nixops |
Not sure you are aware of what this is testing. nixpkgs/nixos/tests/nixops/default.nix Lines 5 to 15 in 5cf75a4
|
I was just building. I'm aware because I wrote that test. |
The darwin builds do still fail. |
I won't be fixing that cause I can't test on Darwin. |
Alright, then I'll merge this. Thank you @dotlambda! |
Backport failed for Please cherry-pick the changes locally. git fetch origin staging-21.11
git worktree add -d .worktree/backport-147049-to-staging-21.11 origin/staging-21.11
cd .worktree/backport-147049-to-staging-21.11
git checkout -b backport-147049-to-staging-21.11
ancref=$(git merge-base 40d43349e66e87b1009cc945e42acd90892f5306 192bbb938c50917e8a411ab0a73cba893dac0dbc)
git cherry-pick -x $ancref..192bbb938c50917e8a411ab0a73cba893dac0dbc |
@NixOS/nixops-committers Someone needs to backport this to 21.11. |
Oops, wrong label. I'll change the generated PR base to fix that. The backport action failed last time for some reason. Let's see if it works now. |
Successfully created backport PR #148255 for |
Motivation for this change
fixes #147034
#144627
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes