Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.05] firefox{,-beta,-devedition,-esr-128}-unwrapped: some prs #356037

Open
wants to merge 3 commits into
base: release-24.05
Choose a base branch
from

Conversation

jopejoe1
Copy link
Member

@jopejoe1 jopejoe1 commented Nov 15, 2024

Backport of #356018 #289404 #349768

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

…iles

makes update script work on devedition and beta

(cherry picked from commit ea8448c)
@jopejoe1 jopejoe1 marked this pull request as ready for review November 15, 2024 00:11
@nix-owners nix-owners bot requested a review from mweinelt November 15, 2024 00:13
@jopejoe1
Copy link
Member Author

CI failure is due the descriptions in packages.nix, being diffrent on 24.05 than on unstable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant