-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Packages.pypdfium2: Fix incorrect hash #378156
Conversation
|
|
This is bizarre: I'm getting a different hash per platform for the same file. |
Closing this, and asking @booxter to please take a look. I suspect you'll need to vary the hash by platform as you do with the binaries. |
}: | ||
|
||
let | ||
pdfiumVersion = "${pdfium-binaries.version}"; | ||
|
||
headers = fetchurl { | ||
url = "https://pdfium.googlesource.com/pdfium/+archive/refs/heads/chromium/${pdfiumVersion}/public.tar.gz"; | ||
hash = "sha256-vKfs4Jd8LEtA3aTI+DcJMS0VOErq1IR1eThnMlxiER0="; | ||
hash = "sha256-RJOhv9v/uI8jYh0hoM7FxGu2lcVV+7BjLkiZW0eX4hk="; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't even the hash obtained in #378154.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote #378154 using x86-Linux but was developing this PR on aarch64-darwin. (The linux box was busy running a nixpkgs-review.) It looks like the hash varies per platform.
The problem is that we're not fetching from a fixed commit. It has nothing to do with different platforms. |
Good to know. I'm passing this back to the package maintainer. |
@@ -9,15 +9,14 @@ | |||
numpy, | |||
pillow, | |||
pytestCheckHook, | |||
python, | |||
}: | |||
|
|||
let | |||
pdfiumVersion = "${pdfium-binaries.version}"; | |||
|
|||
headers = fetchurl { | |||
url = "https://pdfium.googlesource.com/pdfium/+archive/refs/heads/chromium/${pdfiumVersion}/public.tar.gz"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the difference between this URL and https://pdfium.googlesource.com/pdfium/+archive/refs/heads/chromium/${pdfiumVersion}.tar.gz
?
Actually, that's probably not quite it. I assume that the archive is generated on the fly and contains some timestamp, thus the hashes obtained at different times are different. Use either |
OK, I know why he's using fetchurl -- the resulting file contains subfolders where |
I think the issue is that I erroneously refer to a branch, not a tag, so it can change. (I didn't realize that.) We will probably have to pin a particular revision. |
Sent #378177 FYI |
Replaced incorrect hash for headers
Removed unneeded
python
importFixes #378154
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.