Skip to content

Commit

Permalink
Remove direct call to bit64 S3 method to avoid issues in the future.
Browse files Browse the repository at this point in the history
…Fixes #303
  • Loading branch information
schuemie committed Jan 31, 2025
1 parent f0d4790 commit 0794d6e
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
8 changes: 8 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
DatabaseConnector 6.4.1
=======================

Bugfixes:

- Remove direct call to `bit64` S3 method to avoid issues in the future.


DatabaseConnector 6.4.0
=======================

Expand Down
2 changes: 1 addition & 1 deletion R/Sql.R
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ convertInteger64ToNumeric <- function(x) {
if (any(x >= maxInt64 | x <= -maxInt64, na.rm = TRUE)) {
abort("The data contains integers >= 2^53, and converting those to R's numeric type leads to precision loss. Consider using smaller integers, converting the integers to doubles on the database side, or using `options(databaseConnectorInteger64AsNumeric = FALSE)`.")
}
return(bit64::as.double.integer64(x))
return(as.double(x))
}

parseJdbcColumnData <- function(batchedQuery,
Expand Down

0 comments on commit 0794d6e

Please sign in to comment.