Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample Code Optimization - Bot SSO Adaptive Card C# Sample. #1522

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

Harikrishnan-MSFT
Copy link
Contributor

No description provided.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • samples/bot-sso-adaptivecard/csharp/BotSsoAdaptivecard/AdapterWithErrorHandler.cs: Evaluated as low risk
  • samples/bot-sso-adaptivecard/csharp/BotSsoAdaptivecard/Dialogs/MainDialog.cs: Evaluated as low risk
Comments suppressed due to low confidence (3)

samples/bot-sso-adaptivecard/csharp/BotSsoAdaptivecard/Controllers/BotController.cs:44

  • The error message 'Error processing request: {ex.Message}' could be more descriptive and should avoid exposing sensitive information. Consider changing it to 'An error occurred while processing the request. Please try again later.'
await Response.WriteAsync("Error processing request: {ex.Message}");

samples/bot-sso-adaptivecard/csharp/BotSsoAdaptivecard/Bots/TeamsBot.cs:25

  • The error message could be more specific by mentioning the exact configuration key, e.g., 'ConnectionName configuration key is missing.'
logger.LogError("ConnectionName is missing from configuration.");

samples/bot-sso-adaptivecard/csharp/BotSsoAdaptivecard/Bots/TeamsBot.cs:44

  • [nitpick] The word 'universal' should be capitalized to match the rest of the sentence.
await turnContext.SendActivityAsync(MessageFactory.Text("Welcome to Universal Adaptive Cards. Type 'login' to sign in using Universal SSO."), cancellationToken);
@Harikrishnan-MSFT Harikrishnan-MSFT changed the title Sample Code Optimization Sample Code Optimization - Bot SSO Adaptive Card C# Sample. Jan 16, 2025
Copy link
Contributor

@Jegadeesh-MSFT Jegadeesh-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

@Pawank-MSFT
Copy link
Collaborator

Pawank-MSFT commented Jan 31, 2025

Copy link
Collaborator

@Pawank-MSFT Pawank-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks correct, Approving!

@Pawank-MSFT Pawank-MSFT merged commit d345fdf into main Jan 31, 2025
273 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants