-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create New Sample Msgext Thirdparty Storage Python #1533
Create New Sample Msgext Thirdparty Storage Python #1533
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 33 out of 48 changed files in this pull request and generated 1 comment.
Files not reviewed (15)
- samples/msgext-thirdparty-storage/python/.env: Language not supported
- samples/msgext-thirdparty-storage/python/.gitignore: Language not supported
- samples/msgext-thirdparty-storage/python/.vscode/extensions.json: Language not supported
- samples/msgext-thirdparty-storage/python/.vscode/launch.json: Language not supported
- samples/msgext-thirdparty-storage/python/.vscode/settings.json: Language not supported
- samples/msgext-thirdparty-storage/python/.vscode/tasks.json: Language not supported
- samples/msgext-thirdparty-storage/python/appManifest/manifest.json: Language not supported
- samples/msgext-thirdparty-storage/python/assets/sample.json: Language not supported
- samples/msgext-thirdparty-storage/python/env/.env.local: Language not supported
- samples/msgext-thirdparty-storage/python/infra/azure.bicep: Language not supported
- samples/msgext-thirdparty-storage/python/infra/azure.parameters.json: Language not supported
- samples/msgext-thirdparty-storage/python/requirements.txt: Language not supported
- samples/msgext-thirdparty-storage/python/config.py: Evaluated as low risk
- README.md: Evaluated as low risk
- .github/workflows/build-complete-samples.yml: Evaluated as low risk
Comments suppressed due to low confidence (4)
samples/msgext-thirdparty-storage/python/app.py:31
- [nitpick] The error message 'The bot encountered an error or bug.' could be more descriptive to help users understand the issue better.
await context.send_activity("The bot encountered an error or bug.")
samples/msgext-thirdparty-storage/python/README.md:30
- The Python SDK version is mentioned twice with different versions (3.7 and 3.11). This is confusing and should be corrected to a single version.
- [Python SDK](https://www.python.org/downloads/) version 3.7
samples/msgext-thirdparty-storage/python/bots/teams_messaging_extensions_action_bot.py:25
- [nitpick] The function name 'get_file_icon' is ambiguous. It should be renamed to 'get_file_icon_url' to clearly indicate that it returns a URL.
def get_file_icon(self, file_name: str) -> str:
samples/msgext-thirdparty-storage/python/bots/teams_messaging_extensions_action_bot.py:58
- The error message 'Invalid input: Expected an array of files.' could be more descriptive. Consider changing it to 'Invalid input: Expected an array of file objects.'
text="Invalid input: Expected an array of files.",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Correct, Approving..
No description provided.