Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check auto-generated Open Lighting RDM links #1365

Merged
merged 2 commits into from
Jul 16, 2020

Conversation

peternewman
Copy link
Member

As the fixture may not exist

As mentioned in #999

…e as the fixture may not exist

As mentioned in #999
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-1365 July 15, 2020 22:39 Inactive
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-1365 July 16, 2020 15:42 Inactive
@FloEdelmann FloEdelmann added the component-test Affects the automated tests. label Jul 16, 2020
@FloEdelmann FloEdelmann changed the title Don't check auto-generated ones pointing to the Open Lighting RDM site Don't check auto-generated Open Lighting RDM links Jul 16, 2020
@FloEdelmann FloEdelmann merged commit 7aaaf36 into master Jul 16, 2020
@FloEdelmann FloEdelmann deleted the peternewman-no-auto-generated-rdm-links branch July 16, 2020 15:47
@peternewman
Copy link
Member Author

Thanks @FloEdelmann !

@FloEdelmann
Copy link
Member

Thank you for the PR :)

@peternewman
Copy link
Member Author

Presumably they'll vanish from #999 when they get rechecked?

@FloEdelmann
Copy link
Member

That's how it should work, at least 😅
We'll see in about two hours.

@FloEdelmann
Copy link
Member

It did work, the RDM pages vanished from #999 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-test Affects the automated tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants