Clean up transfer_liquid implementation for argument-passing hygiene #17244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ddcc4
commented
Jan 10, 2025
ddcc4
commented
- Functions should not modify any argument that's passed in (unless that's the purpose of the function).
- Objects should not modify any arguments given to their constructor (unless the object is supposed to take ownership of the argument).
- Functions should not modify any argument that's passed in (unless that's the purpose of the function). - Objects should not modify any arguments given to their constructor (unless the object is supposed to take ownership of the argument).
sanni-t
approved these changes
Jan 10, 2025
ddcc4
merged commit 8d4bfa5
into
AUTH-866-add-transfer-flow-builder-final
26 of 27 checks passed
sanni-t
pushed a commit
that referenced
this pull request
Jan 15, 2025
…17244) - Functions should not modify any argument that's passed in (unless that's the purpose of the function). - Objects should not modify any arguments given to their constructor (unless the object is supposed to take ownership of the argument).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.