Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): Fix copy/CSS for stall/collision recovery DQA #17298

Merged
merged 2 commits into from
Jan 21, 2025
Merged

refactor(app): Fix copy/CSS for stall/collision recovery DQA #17298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
776f739
refactor(app): fix ODD ER intervention modal icon size
mjhuff Jan 17, 2025
1331c3f
refactor(app): update retry step generic copy
mjhuff Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/assets/localization/en/error_recovery.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
"stand_back_retrying": "Stand back, retrying failed step",
"stand_back_skipping_to_next_step": "Stand back, skipping to next step",
"take_any_necessary_precautions": "Take any necessary precautions before positioning yourself to stabilize or catch the labware. Once confirmed, a countdown will begin before the gripper releases.",
"take_necessary_actions": "<block>First, take any necessary actions to prepare the robot to retry the failed step.</block><block>Then, close the robot door before proceeding.</block>",
"take_necessary_actions": "<block>Take any necessary additional actions to prepare the robot to retry the failed step.</block><block>Close the robot door before proceeding.</block>",
"take_necessary_actions_failed_pickup": "<block>First, take any necessary actions to prepare the robot to retry the failed tip pickup.</block><block>Then, close the robot door before proceeding.</block>",
"take_necessary_actions_failed_tip_drop": "<block>First, take any necessary actions to prepare the robot to retry the failed tip drop.</block><block>Then, close the robot door before proceeding.</block>",
"take_necessary_actions_home": "<block>Take any necessary actions to prepare the robot to move the gantry to its home position.</block><block>Close the robot door before proceeding.</block>",
Expand Down
2 changes: 1 addition & 1 deletion app/src/organisms/ErrorRecoveryFlows/shared/RecoveryInterventionModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export function RecoveryInterventionModal({
}

return createPortal(
<InterventionModal {...restProps}>
<InterventionModal {...restProps} iconSize={isOnDevice ? '28px' : '16px'}>
<Flex
css={
desktopType === 'desktop-small'
Expand Down
4 changes: 2 additions & 2 deletions app/src/organisms/ErrorRecoveryFlows/shared/__tests__/RetryStepInfo.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,8 @@ describe('RetryStepInfo', () => {
render(props)

screen.getByText(
'First, take any necessary actions to prepare the robot to retry the failed step.'
'Take any necessary additional actions to prepare the robot to retry the failed step.'
)
screen.getByText('Then, close the robot door before proceeding.')
screen.getByText('Close the robot door before proceeding.')
})
})
Loading