-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api):show plate reader files in run log #17369
fix(api):show plate reader files in run log #17369
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me!
@@ -181,6 +181,9 @@ async def execute( # noqa: C901 | |||
) | |||
) | |||
file_ids.append(file_id) | |||
state_update.files_added = update_types.FilesAddedUpdate( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will assign every measurement iteration, we should pull this out of the for loop so assignment happens once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
Overview
closes https://opentrons.atlassian.net/browse/RQA-3867.
append file names to state when given file name.
Test Plan and Hands on Testing
run the following protocol and make sure the files appear in the run log.
see screenshot of example worked:
Changelog
append file names to state.
Review requests
changes make sense?
Risk assessment
low. bug fix.