-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix numerous fullDPS tooltip issues #8247
Fix numerous fullDPS tooltip issues #8247
Conversation
Using the same PoB i used here to test things: First doig the same test as in my comment linked above.
|
1c14f06
to
90baaff
Compare
Marking as ready for review as i can't think of anything else to test. Tested:
|
This seems to fix the bug I noticed recently where the FullDPS line is absent from item tooltips when PoB auto-loads the last saved build on startup. Not extensively tested though. |
118e0b4
into
PathOfBuildingCommunity:dev
Fixes #8245 #8163
Description of the problem being solved:
There exist multiple issues with fullDPS breakdowns not showing up or showing up when they shouldn't be. This pr attempts to address those issues.
Marking as draft and there are probably many more edge cases i have not yet considered. Especially around trader functionality.
Steps taken to verify a working solution: