Merge pull request #726 from Polymer/fix-memory-leak

Clear share from ChildRunner to prevent memory leak. Fixes #579
Polymer · Jul 17, 2018 · e68b2cb · e68b2cb
2 parents 3bef18f + f8b52c3
commit e68b2cb
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 3 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -10,8 +10,8 @@ addons:
   sauce_connect: true
 language: node_js
 node_js:
-- node
 - '6'
+- '8'
 script:
 - xvfb-run npm test
 env:

diff --git a/browser.js b/browser.js
diff --git a/browser.js.map b/browser.js.map
diff --git a/browser/childrunner.ts b/browser/childrunner.ts
@@ -178,6 +178,7 @@ export default class ChildRunner {
     setTimeout(function() {
       this.iframe.parentNode.removeChild(this.iframe);
       this.iframe = null;
+      this.share = null;
     }.bind(this), 1);
   }
 

diff --git a/wct-browser-legacy/browser.js b/wct-browser-legacy/browser.js
diff --git a/wct-browser-legacy/browser.js.map b/wct-browser-legacy/browser.js.map