Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NovaStream): add activity #9232

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(NovaStream): add activity #9232

wants to merge 5 commits into from

Conversation

Lenochxd
Copy link

Description

Acknowledgements

Screenshots

Proof showing the creation/modification is working as expected

Movies:
image
Shows:
image
Search:
image
Watch Later:
image
Homepage:
image

@ambr0sial
Copy link

i approve

kaipicpic
kaipicpic approved these changes Jan 30, 2025
View reviewed changes
Copy link

@kaipicpic kaipicpic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i appwove :>

@Lenochxd
Copy link
Author

girl you're not even a maintainer

@ambr0sial
Copy link

girl you're not even a maintainer

i approve

@kaipicpic
Copy link

i don't understand anything anymore 😭

@ambr0sial
Copy link

i don't understand anything anymore 😭

i approve

@kaipicpic
Copy link

i don't understand anything anymore 😭

i approve

shushh

theusaf
theusaf requested changes Jan 30, 2025
View reviewed changes
websites/N/NovaStream/presence.ts Outdated Show resolved Hide resolved
@Lenochxd
fix: use generics instead of casting
9d0516e 
`as HTMLInputElement` -> `querySelector<HTMLInputElement>`
`as HTMLSelectElement` -> `querySelector<HTMLSelectElement>`
@theusaf theusaf requested a review from Bas950 February 3, 2025 21:43
@theusaf theusaf enabled auto-merge (squash) February 3, 2025 21:43
darkvillager2
darkvillager2 suggested changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@darkvillager2 darkvillager2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

Thanks for your PR. I have some issues with your code.

If you have any questions about my requested changes feel free to ask in here or on discord (@Dark_Ville) 👯‍♂️

websites/N/NovaStream/presence.ts Outdated Show resolved Hide resolved
websites/N/NovaStream/presence.ts Outdated Show resolved Hide resolved
websites/N/NovaStream/presence.ts Outdated Show resolved Hide resolved
websites/N/NovaStream/presence.ts Outdated Show resolved Hide resolved
auto-merge was automatically disabled February 5, 2025 23:15

Head branch was pushed to by a user without write access

@Lenochxd
fix: refactor presence data extraction to use more reliable selectors
28c21a6 
- Simplified the logic for extracting presence data: updated selectors for release date, rating, runtime, season, and episode to use `x-text` and `x-model` attributes.
@Lenochxd
fix: watchlist not working properly
47e157b
@Lenochxd
Copy link
Author

Lenochxd commented Feb 5, 2025

You are right, if the author of the site adds an element the presence could break if I kept using p:nth-child. Fixed :)

Proof that presence still works well

image
image
image

@theusaf theusaf enabled auto-merge (squash) February 5, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkvillager2 darkvillager2 darkvillager2 requested changes

@theusaf theusaf theusaf approved these changes

@kaipicpic kaipicpic kaipicpic approved these changes

@Bas950 Bas950 Awaiting requested review from Bas950

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
activity creation
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Lenochxd @ambr0sial @kaipicpic @theusaf @darkvillager2