chore(AnimeLib): settings in native language #9237
Open
+26
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
types(AnimeLib): typed routes
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -56,7 +75,8 @@ | |||
| presence.getSetting<boolean>("buttons"), | |||
| presence.getSetting<boolean>("titleAsPresence"), | |||
| ]), | |||
| path = document.location.pathname; | |||
| path = document.location.pathname, | |||
| route = <RouteName>`${path}/`.split("/")[2]; | |||
Check warning
Code scanning / ESLint
Variable 'route' is only used once. Warning
theusaf
approved these changes
Feb 3, 2025
| @@ -56,7 +75,8 @@ presence.on("UpdateData", async () => { | |||
| presence.getSetting<boolean>("buttons"), | |||
| presence.getSetting<boolean>("titleAsPresence"), | |||
| ]), | |||
| path = document.location.pathname; | |||
| path = document.location.pathname, | |||
| route = <RouteName>`${path}/`.split("/")[2]; | |||
There was a problem hiding this comment.
Not really an improvement imo.
There was a problem hiding this comment.
It just hurts me a bit to keep it in the switch statement.
Anyway, the linting about using a variable only once will be removed soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
types(AnimeLib): typed routes
Description
Acknowledgements
yarn formatScreenshots
Proof showing the creation/modification is working as expected