Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target wait warning to more specific circumstances #16969

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Target wait warning to more specific circumstances #16969

merged 3 commits into from
Feb 5, 2025

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Feb 4, 2025

Closes #16848

@github-actions github-actions bot added the bug Something isn't working label Feb 4, 2025
@cicdw cicdw changed the title Target warning to more specific circumstances Target wait warning to more specific circumstances Feb 4, 2025
@cicdw cicdw mentioned this pull request Feb 4, 2025
Closed
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 4, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #16969 will not alter performance

Comparing more-targeted-warning (b443dba) with main (2e656b6)

Summary

✅ 2 untouched benchmarks

desertaxle
desertaxle reviewed Feb 5, 2025
View reviewed changes
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good! It'd probably be worthwhile to add a test to avoid future regression.

@cicdw
Copy link
Member Author

cicdw commented Feb 5, 2025

@desertaxle done ✅

@github-actions github-actions bot added the docs label Feb 5, 2025
@cicdw cicdw merged commit bda5a5c into main Feb 5, 2025
50 of 51 checks passed
@cicdw cicdw deleted the more-targeted-warning branch February 5, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desertaxle desertaxle desertaxle approved these changes

@zzstoatzz zzstoatzz Awaiting requested review from zzstoatzz zzstoatzz is a code owner

@aaazzam aaazzam Awaiting requested review from aaazzam aaazzam is a code owner

@kevingrismore kevingrismore Awaiting requested review from kevingrismore kevingrismore is a code owner

@daniel-prefect daniel-prefect Awaiting requested review from daniel-prefect daniel-prefect is a code owner

@seanpwlms seanpwlms Awaiting requested review from seanpwlms seanpwlms is a code owner

Assignees
No one assigned
Labels
bug Something isn't working docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to correct close all submited tasks?
2 participants
@cicdw @desertaxle