Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New task: Rename Uncategorized category #266

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

ilicfilip
Copy link
Collaborator

Context

New task for renaming Uncategorized category.

We still need to decide:

  • if we check just category name or the slug as well.
  • do we offer a suggestion to user to what category should be renamed.

Quality assurance

  • I have tested this code to the best of my abilities.
  • I have added unit tests to verify the code works as intended.
  • I have checked that the base branch is correctly set.

Fixes https://github.com/ProgressPlanner/progress-planner-pro/issues/77

Copy link
Contributor

github-actions bot commented Feb 13, 2025

Test on Playground
Test this pull request on the Playground or download the zip.

@ilicfilip ilicfilip requested a review from aristath February 14, 2025 10:58
'url' => $this->capability_required() ? \esc_url( \admin_url( 'edit-tags.php?taxonomy=category&post_type=post' ) ) : '',
'description' => '<p>' . sprintf(
/* translators: %s: php version */
\esc_html__( 'The Uncategorized category is used for posts that don\'t have a category. We recommend renaming it to something more descriptive, like "Posts without a category".', 'progress-planner' ),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posts without a category is just as bad as Uncategorized... I don't think we should recommend something specific, it should be something that makes sense for their own site. If for example it's a news site then news would make more sense. "Uncategorized" should be changed to whatever makes sense as default for their site 🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a placeholder, we havent still decided what would be best to suggest 😄

@ilicfilip ilicfilip marked this pull request as ready for review February 14, 2025 11:36
@ilicfilip ilicfilip requested a review from aristath February 14, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants