-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-version notebook support #232
Draft
MichaelHatherly
wants to merge
3
commits into
main
Choose a base branch
from
mh/multi-version-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelHatherly
force-pushed
the
mh/multi-version-2
branch
from
January 14, 2025 16:30
b90b7af
to
6449999
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
==========================================
- Coverage 37.14% 31.05% -6.10%
==========================================
Files 41 52 +11
Lines 1642 2389 +747
==========================================
+ Hits 610 742 +132
- Misses 1032 1647 +615 ☔ View full report in Codecov by Sentry. |
MichaelHatherly
force-pushed
the
mh/multi-version-2
branch
12 times, most recently
from
January 15, 2025 22:04
a66055f
to
64f3f4b
Compare
MichaelHatherly
force-pushed
the
mh/multi-version-2
branch
2 times, most recently
from
January 16, 2025 16:54
9bb4065
to
e550ab1
Compare
Add a barrier function in the `show` code path to make stacktrace cleaning more robust. Previous logic produced inconsistent results between macOS x64 and ARM due to differences in the frames included in stacktraces, ie. there were missing `invokelatest` frames that impacted the stacktrace cutoff point.
MichaelHatherly
force-pushed
the
mh/multi-version-2
branch
from
January 17, 2025 09:50
602028f
to
91a232d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for running notebook processes that are different Julia versions than the main runner process. To start a different Julia version in a notebook use
juliaup
channel syntax in thejulia.exeflags
frontmatter for the notebook. You must already have that channel name installed:Previously this did not work since QNR used
Malt.jl
for managing them, and that package usesSerialization.jl
for the communication between processes. Serialization is limited to only being about to deserialize data from the same version of Julia, hence it blocked supporting running multiple Julia versions in our Quarto notebooks.This PR vendors
Malt.jl
and adjusts some code to allow for starting up and sending data across different versions ofjulia
. Instead ofSerialization
we useBSON
for serialization which manages to work across versions for the limited kinds of data that QNR uses, basically just strings, arrays of uint8, namedtuples and numbers.In addition this also implements what was discussed in #215 to throw more informative errors when the Julia version running and the
julia_version
field in aManifest.toml
file do not match, which can, if ignored, lead to hard to diagnose errors on notebook startup. We now throw a hard error when there is a mismatch, and guide the user to a solution by either picking a different Juliaup channel, or re-resolving the manifest file.Take 2 of #230.