Update to Pyo3 v0.22 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Potentially rebase on main please, and then CI should run :) |
bschoenmaeckers
force-pushed
the
pyo3_v0.22
branch
from
780b502 to
fd70e99
Compare
|
I'll wait for this one to be merged before I do anything else, so we're not stepping on each other 😄 |
davidhewitt
approved these changes
Oct 11, 2024
|
|
||
| if let Err(e) = R::spawn_local(async move { | ||
| let result = R::scope_local( | ||
| locals2.clone(), | ||
| Python::with_gil(|py| locals2.clone_ref(py)), |
There was a problem hiding this comment.
I think these patterns are all correct for now. It would be interesting to explore further what we can do to reduce calls to Python::with_gil, and the correct way to release the GIL across yield points too.
I think they are follow up areas of research, which probably can yield new APIs both here and upstream in PyO3.
(I guess there's potentially a lot of interesting performance benchmarking to do?)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first attempt at updating to pyo3 v0.22 without the
py-clonefeature. I've added aPython::with_gilnaively everywhere a GIL token was required, so it may need some refactoring & cleanup next. Furthermore all fmt/cargo checks should be resolved.ref #1