-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: disable font preloading option in qwikVite #7297
base: main
Are you sure you want to change the base?
Conversation
|
cc @QwikDev/core-veterans the font preloading code will be removed entirely post v2 and replaced with fontless. I was considering doing an e2e test that verifies the link tags existence, but if this code is going to be removed entirely in v2, maybe a test in vitest with a mock of whether the code executes or not would be better? I have verified that when I should also mention that the code that preloads these fonts is already flaky as is, some self hosted fonts don't get preloaded altogether, so this functionality is currently brittle to begin with. I have a demo project that was able to reproduce the font preloading behavior. |
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
* | ||
* Disabling may impact Cumulative Layout Shift (CLS) metrics. | ||
*/ | ||
disableFontPreload?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since CI passes and there's no API changes, I think you need to put this jsdoc elsewhere
What is it?
Description
Checklist
pnpm change