Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): make pnpm work again #7306

Merged
merged 1 commit into from
Feb 3, 2025
Merged

fix(ci): make pnpm work again #7306

merged 1 commit into from
Feb 3, 2025

Conversation

wmertens
Copy link
Member

@wmertens wmertens commented Feb 3, 2025

this fixes the problems caused by nodejs/corepack#612

We no longer rely on corepack to get the correct pnpm version, and we hope that pnpm/action-setup@v4 will do the right thing.

@wmertens wmertens requested a review from a team as a code owner February 3, 2025 16:13
@wmertens wmertens enabled auto-merge February 3, 2025 16:13
Copy link

changeset-bot bot commented Feb 3, 2025

⚠️ No Changeset found

Latest commit: dd5ab08

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wmertens wmertens force-pushed the fix-ci-pnpm branch 5 times, most recently from 77e1e8f to 6ed5784 Compare February 3, 2025 17:55
Copy link

pkg-pr-new bot commented Feb 3, 2025

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@7306
npm i https://pkg.pr.new/@builder.io/qwik-city@7306
npm i https://pkg.pr.new/eslint-plugin-qwik@7306
npm i https://pkg.pr.new/create-qwik@7306

commit: dd5ab08

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me
@wmertens thanks

@wmertens wmertens merged commit 0a254ea into main Feb 3, 2025
18 of 21 checks passed
@wmertens wmertens deleted the fix-ci-pnpm branch February 3, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants