fix: rendering attribute value from array of classes from spread props #7310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7c241ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Varixo
force-pushed
the
v2-class-array-rest-props
branch
3 times, most recently
from
3573ed4 to
0f4fbce
Compare
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
wmertens
reviewed
Feb 5, 2025
| @@ -48,6 +49,10 @@ export abstract class _SharedContainer implements Container { | |||
| return trackSignalAndAssignHost(signal, subscriber, property, this, data); | |||
| } | |||
|
|
|||
| serializeAttributeValue(key: string, value: any, styleScopedId?: string | null) { | |||
There was a problem hiding this comment.
yes, I forgot about reverting that change
Varixo
force-pushed
the
v2-class-array-rest-props
branch
from
0f4fbce to
e6d5b10
Compare
Varixo
force-pushed
the
v2-class-array-rest-props
branch
from
e6d5b10 to
7c241ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.