Check expiration of token #218
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -90,6 +91,11 @@ def validate_token_request(self, request): | |||
|
|
|||
| try: | |||
| user = backend.do_auth(access_token=request.token) | |||
| user_data = backend.user_data(access_token=request.token) | |||
| exp = user_data['exp'] | |||
There was a problem hiding this comment.
exp is the expiration date of the token
Co-Authored-By: Wagner de Lima <[email protected]>
wagnerdelima
approved these changes
Apr 14, 2020
bmpenuelas
reviewed
Dec 12, 2020
| @@ -90,6 +91,11 @@ def validate_token_request(self, request): | |||
|
|
|||
| try: | |||
| user = backend.do_auth(access_token=request.token) | |||
| user_data = backend.user_data(access_token=request.token) | |||
| exp = user_data['exp'] | |||
| if not exp and exp <= datetime.now(): | |||
There was a problem hiding this comment.
The not operator having higher precedence makes this always evaluate to False whenever exp evaluates to True. Can you please explain the desired operation here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code doesn't check to see if the supplied access token is expired.
This adds a check for the
expfield of the JWT