Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using theta as the driver for VegasFlow #56

Draft
wants to merge 38 commits into
base: master
Choose a base branch
from

Conversation

scarlehoff
Copy link

I've been working on using the RTBM as the integration driver for VegasFlow (i.e., instead of using the Vegas algorithm for sampling, using the RTBM). For that I needed several changes, some of them 100% needed (like the transformation to the sampling) although they could be if needed in the VegasFlow side.
Some are really needed inside the RTBM but are there just to facilitate the optimization (the gaussian initialization and forcing positivity through the cholesky decomposition).
The PR that implements the RTBM can be seen in: N3PDF/vegasflow#68

The main changes that this PR introduces are:

  • The possibility to save (and thus train) the parameters of the RTBM as the cholesky decomposition of the matrices (to ensure positivity).
  • Gaussian initialization (a bit modified but mainly @scarrazza version)
  • Transformation to the sampling (and the corresponding jacobian) to ensure the sampling is fixed between 0 and 1.
  • Inverse transformation (could be useful for training, still not sure)

There are, however, many points that need to be improved. The main that comes to mind is the fact that the boundaries don't really mean much now as I haven't really transformed then that much.

Note: There are many changes in this PR (and not all of them useful) so I don't think this should be merge as is, but since @scarrazza is thinking on maybe having a student work on this, it's better if they have all changes available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant