Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bash script with English version and Add readme.file #103

Closed
wants to merge 9 commits into from

Conversation

wickdynex
Copy link
Contributor

Overview of Changes

  1. Add new feature to install.sh: specify the install version.
  2. Fix the install.sh bugs: aarch64 is also arm64, add the new arch into case statement.
  3. Add readme.txt: it can direct user install more easily.
  4. Add English Install Version: in order to avoid the os can't display Chinese, I add the English script version.

Related Issues

Fixed #98

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Code refactoring

Impact

Fix the install bugs, and make scripts more readable and usable.

Pretending Test

Use install-en.sh and install.sh to install any version on any architect and os.

@ccmywish ccmywish added Release Release Challenge Challenge labels Oct 25, 2024
@ccmywish
Copy link
Contributor

Hi @1328032567

I really appreciate your work and the idea of considering about the English output, it indeed is a goal of chsrc. 👍

However, the install.sh's original author @Efterklang implement -v sooner than your PR, so I decided to merge his work.

The rest of your work is worth merging.

Could you please directly add a -en(glish) option to the install.sh to output in English? That way we don't have to maintain two pieces of code.

I'll close this PR, and please based on the newest dev branch to re-add your code in a new PR, thank you very much! 🤝

@ccmywish ccmywish closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Challenge Challenge Release Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants