Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug and Append the author and contribut #105

Closed
wants to merge 3 commits into from

Conversation

wickdynex
Copy link
Contributor

@wickdynex wickdynex commented Oct 25, 2024

Overview of Changes

  1. Use shellcheck tool to check the install.sh file's syntax.
  2. Append me and partner's name to install.sh file's author.
  3. Add name to chars-main.c.

Related Issues

Fixed #98

Type of Change

  • Bug fix
  • Add name

Problem

How can I forget to create a new branch to add the contributors name. Im sorry about that.

@ccmywish
Copy link
Contributor

Please always sync with dev branch first. Don't develop on your old PR branch, the auto merging will corrupt your code, for example: https://github.com/1328032567/chsrc/blob/update-bash-script/tool/install.sh#L104-L105

你每次提交以后,我都会在审阅之后,快速做出一些修改并 push 到 devmain 两个分支上。比如 elif 问题,我审查代码的时候已经帮你修订过来了。所以如果你再基于旧的 PR 分支开发,就会冲突。所以你应该重新开一个分支来与 dev 保持同步之后,再做出修改。

另外,我认为 ChatGPT 4o mini4o miniChatGPT 的版本信息,没有必要写下来。就像一个开发者一样,不必标注 Bob 18 years oldJohn 2 years dev。如果别人也用了 ChatGPT 的话,版本不一样,则要记录数条 ChatGPT 5,6,7..n

@wickdynex
Copy link
Contributor Author

Please always sync with dev branch first. Don't develop on your old PR branch, the auto merging will corrupt your code, for example: https://github.com/1328032567/chsrc/blob/update-bash-script/tool/install.sh#L104-L105

你每次提交以后,我都会在审阅之后,快速做出一些修改并 push 到 devmain 两个分支上。比如 elif 问题,我审查代码的时候已经帮你修订过来了。所以如果你再基于旧的 PR 分支开发,就会冲突。所以你应该重新开一个分支来与 dev 保持同步之后,再做出修改。

另外,我认为 ChatGPT 4o mini4o miniChatGPT 的版本信息,没有必要写下来。就像一个开发者一样,不必标注 Bob 18 years oldJohn 2 years dev。如果别人也用了 ChatGPT 的话,版本不一样,则要记录数条 ChatGPT 5,6,7..n

Sorry, I messed it up. I'll close this pr and create a new one which is a new branch from the latest dev, also rename the ChatGPT at the same time.

@wickdynex wickdynex closed this Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants