-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow nil to be used as a default_currency #1095
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add an entry to the CHANGELOG as well? 🙏🏻
Co-authored-by: Sunny Ripert <[email protected]>
@sunny Yeah my bad, updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
We would love to see this included as well. A default currency is a hard no for our use case. Is there any chance to get this merged anytime soon? |
Any chance this can get merged? |
This is a part of fixing the RubyMoney/money-rails#697