Fix up datagrid layout #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +89 B (0%) Total Size: 89.8 kB
ℹ️ View Unchanged
|
github-actions
bot
force-pushed
the
release-9.2.7
branch
from
c127169 to
f8b84bd
Compare
|
Sorry y'all, I forgot to add you as reviewers 🙈 |
shawnbot
force-pushed
the
release-9.2.7
branch
2 times, most recently
from
9cadba3 to
6c3d478
Compare
coreyhunt
approved these changes
Jun 7, 2022
shawnbot
added a commit
that referenced
this pull request
Jun 28, 2022
* bump v9.2.7 * fix(api): prevent access errors in undefined form.form.properties (#224) * fix(datagrid): remove v-align-top class from <tr> (#226) * chore(npm): npm audit fix * Fix up datagrid layout (#228) * fix(css): add .form-comtrol padding, height * fix(templates): fix up datagrid markup + classes Co-authored-by: [email protected] Co-authored-by: [email protected] * fix(examples): add datagrid example * chore(templates): nix table-layout style from datagrid * chore(deps): npm audit fix * Fix/radio required visual indicator (#235) * fix(radio): add required style to <legend> * chore(tests): update snapshots for required radio * fix(syntax): nix ?. operators * chore(tests): update snapshots * Fix select component option translation (#236) * chore(tests): add example for select w/translations * fix(i18n): make select labels explicitly translatable * chore(tests): update snapshots Co-authored-by: Shawn Allen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #227
@nlsfds @coreyhunt you can test it by adding this query string to any form page on SF.gov, as in the ADU form:
Then, either run this in the console:
or paste this into the location bar and press Enter: