Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(heading): maintain layout when title prop is set to null #7165

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(heading): maintain layout when title prop is set to null #7165

wants to merge 1 commit into from
+49 −11

Conversation

DobroTora
Copy link
Contributor

@DobroTora DobroTora commented Jan 20, 2025 •
edited
Loading

Proposed behaviour

Screenshot 2025-01-30 at 10 47 00 Screenshot 2025-01-30 at 10 47 13 Screenshot 2025-01-30 at 10 47 32

Current behaviour

Screenshot 2025-01-30 at 10 39 50

#5460

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

Screen.Recording.2025-01-21.at.17.06.14.mov

@DobroTora DobroTora requested a review from a team as a code owner January 20, 2025 15:36
@DobroTora DobroTora marked this pull request as draft January 22, 2025 09:34
@DobroTora DobroTora self-assigned this Jan 22, 2025
@Parsium Parsium self-requested a review January 31, 2025 09:59
@DobroTora DobroTora force-pushed the FE-5367 branch 2 times, most recently from 4164840 to a1779bb Compare February 3, 2025 10:46
Parsium

This comment was marked as resolved.

Sign in to view

@Parsium

This comment was marked as resolved.

Sign in to view
@Parsium
Copy link
Contributor

Parsium commented Feb 3, 2025

Thanks for the updates @DobroTora 👍🏼 Just a few comments from me

DipperTheDan
DipperTheDan reviewed Feb 3, 2025
View reviewed changes
src/components/heading/heading.style.ts Outdated Show resolved Hide resolved
src/components/pages/page/page.component.tsx Outdated Show resolved Hide resolved
src/components/pages/pages-test.stories.tsx Outdated Show resolved Hide resolved
src/components/pages/pages-test.stories.tsx Outdated Show resolved Hide resolved
src/components/dialog-full-screen/dialog-full-screen.style.ts Outdated Show resolved Hide resolved
src/components/dialog-full-screen/dialog-full-screen.component.tsx Outdated Show resolved Hide resolved
Parsium
Parsium reviewed Feb 5, 2025
View reviewed changes
Copy link
Contributor

@Parsium Parsium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments @DobroTora 👍🏼

It appears the negative margin issue is still occurring. Would you mind taking a look when you get a chance?

@DobroTora DobroTora force-pushed the FE-5367 branch 2 times, most recently from 4ceae73 to ae1dd29 Compare February 5, 2025 15:53
@DobroTora
Copy link
Contributor Author

Thanks for addressing the comments @DobroTora 👍🏼

It appears the negative margin issue is still occurring. Would you mind taking a look when you get a chance?

Hi, so I had a look and test this story and I hope I resolved the issue.
Screenshot 2025-02-05 at 14 09 31

Parsium
Parsium approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@Parsium Parsium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @DobroTora ✅

@DobroTora DobroTora marked this pull request as ready for review February 7, 2025 10:02
@DobroTora DobroTora requested a review from a team as a code owner February 7, 2025 10:02
@edleeks87 edleeks87 marked this pull request as draft February 7, 2025 10:32
@edleeks87 edleeks87 marked this pull request as ready for review February 7, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edleeks87 edleeks87 edleeks87 left review comments

@Parsium Parsium Parsium approved these changes

@DipperTheDan DipperTheDan DipperTheDan approved these changes

Assignees

@DobroTora DobroTora

Labels
Passed Review Pending QA Squad Front End
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DobroTora @Parsium @edleeks87 @DipperTheDan