feat(fieldset): add support for new validation designs #7190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates `Fieldset` component to support new validation designs by removing the zero margin spacing on the input fields within the component. The component will now also consume `fieldSpacing` from `Form`, which will be applied to all fields within it.
nuria1110
commented
Feb 3, 2025
There was a problem hiding this comment.
Moved these examples with legacy styles to test stories as we don't want them in the docs page, but we still want Chromatic to capture them as they are still supported with legacy validations.
damienrobson-sage
approved these changes
Feb 5, 2025
DipperTheDan
approved these changes
Feb 5, 2025
| display: flex; | ||
| align-items: center; | ||
| margin-bottom: 32px; | ||
| font-size: 20px; | ||
| margin-bottom: var(--spacing250); |
There was a problem hiding this comment.
praise: Well done for making these design token values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Updates
Fieldsetcomponent to support new validation designs by removing the zero margin spacing on the input fields within the component. The component will now also consumefieldSpacingfromForm, which will be applied to all fields within it.Current behaviour
Fieldsetdoes not support new validation designs and does not consumefieldSpacingfrom `Form.Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions