Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename strategy name to match devise omniauth patterns #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,5 +75,5 @@ following ENV variables set:
* `COGNITO_POOL_SITE`: The domain attached to the user pool.

The application will start at `http://localhost:8678`. You will have to add a callback URL
`http://localhost:8678/auth/cognito-idp/callback` to the client application in the AWS Console. The test app stores the
`http://localhost:8678/auth/cognito_idp/callback` to the client application in the AWS Console. The test app stores the
tokens in memory, so you will need to sign in again after restarting the server.
2 changes: 1 addition & 1 deletion config.ru
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class TestApp < Sinatra::Base
<pre>#{session[:auth].pretty_inspect}</pre>
<h2>Links</h2>
<ul>
<li><a href="/auth/cognito-idp">Sign In</a></li>
<li><a href="/auth/cognito_idp">Sign In</a></li>
<li><a href="/userinfo">Userinfo</a></li>
</ul>
</body>
Expand Down
2 changes: 1 addition & 1 deletion lib/omniauth-cognito-idp/version.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# frozen_string_literal: true

module OmniAuthCognitoIdP
VERSION = '0.1.1'
VERSION = '0.2.0'
end
2 changes: 1 addition & 1 deletion lib/omniauth/strategies/cognito_idp.rb
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ module OmniAuth
module Strategies
# OmniAuth strategy that authenticates against an Amazon Cognito User Pool
class CognitoIdP < OmniAuth::Strategies::OAuth2
option :name, 'cognito-idp'
option :name, 'cognito_idp'
option :client_options,
{
authorize_url: '/oauth2/authorize',
Expand Down