Skip to content

Commit

Permalink
Merge pull request #504 from Sylfrena/dev
Browse files Browse the repository at this point in the history
Add troubleshooting to docs for higher Ruby versions
  • Loading branch information
Shekharrajak authored May 6, 2019
2 parents d17887e + dea4055 commit eb2380d
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@ doc/
vendor/
profile/out/
coverage/
.ruby-version
9 changes: 9 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,21 @@ And run the test suite (should be all green with pending tests):

If you have problems installing nmatrix, please consult the [nmatrix installation wiki](https://github.com/SciRuby/nmatrix/wiki/Installation) or the [mailing list](https://groups.google.com/forum/#!forum/sciruby-dev).

**NOTE**: `Daru` is compatible with Ruby versions < 2.5; for later Ruby versions it breaks, returning the following error in versions >= 2.5.
```
/gems/packable-1.3.10/lib/packable/extensions/io.rb:86:in `pos': Illegal seek @ rb_io_tell - <STDOUT> (Errno::ESPIPE)
```
To reproduce this issue or explore this error further, head over to
[issue #500](https://github.com/SciRuby/daru/issues/500),
[issue #503](https://github.com/SciRuby/daru/issues/503). Also, if you want to fix this issue, then please discuss it here : [#505](https://github.com/SciRuby/daru/issues/500)

While preparing your pull requests, don't forget to check your code with Rubocop:

`bundle exec rubocop`

[Optional] Install all Ruby versions which Daru currently supports with `rake spec setup`.


## Basic Development Flow

1. Create a new branch with `git checkout -b <branch_name>`.
Expand Down

0 comments on commit eb2380d

Please sign in to comment.