Support auto-completion on every preset setting

Shopify · Jan 16, 2025 · 0de2a0f · 0de2a0f
1 parent c74850c
commit 0de2a0f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/.changeset/plenty-radios-drum.md b/.changeset/plenty-radios-drum.md
@@ -0,0 +1,5 @@
+---
+'@shopify/theme-language-server-common': patch
+---
+
+[Bug fix] Support auto-completion on every preset setting
diff --git a/...server-common/src/json/completions/providers/PresetsSettingsPropertyCompletionProvider.ts b/...server-common/src/json/completions/providers/PresetsSettingsPropertyCompletionProvider.ts
@@ -100,9 +100,5 @@ export class PresetsSettingsPropertyCompletionProvider implements JSONCompletion
 }
 
 function isPresetSettingsPath(path: JSONPath) {
-  return path.at(0) === 'presets' && path.at(1) === 0 && path.at(2) === 'settings';
-}
-
-function isTranslationKey(path: string) {
-  return path.startsWith('t:');
+  return path.at(0) === 'presets' && path.at(2) === 'settings';
 }