Support content_for block type completion + document link
#709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karreiro
reviewed
Jan 15, 2025
|
|
||
| return (await this.getThemeBlockNames(doc.uri, false)).map((blockName) => ({ | ||
| label: blockName, | ||
| kind: CompletionItemKind.Keyword, |
There was a problem hiding this comment.
It doesn't seem like we're completing a keyword, so I personally believe we should use CompletionItemKind.EnumMember, as the completion items are part of a well-defined set of options (standardized and formally grouped).
Alternatively, we could use CompletionItemKind.Value as well, but it doesn't seem so ideal since it refers to literal values not tied to a certain group.
(Just mentioning this because this impacts the icons of the completion items, so it also gives extra clues for users) :)
aswamy
force-pushed
the
feature/content_for-block-type-completion
branch
from
b16e3ec to
2cba55f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
Fixes #571
Support
content_forblock type completion + document linkBefore you deploy
changeset