Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blocks): Add jina fact checker block #8409

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from

Conversation

Bentlybro
Copy link
Member

@Bentlybro Bentlybro commented Oct 23, 2024

Background

This adds the new Jina fact checker api as a block
https://jina.ai/news/fact-checking-with-new-grounding-api-in-jina-reader/

video to show it working with the new auth system!

2024-10-23.15-20-57.mp4

@Bentlybro Bentlybro requested a review from a team as a code owner October 23, 2024 12:46
@Bentlybro Bentlybro requested review from Torantulino and majdyz and removed request for a team October 23, 2024 12:46
@github-actions github-actions bot added the platform/frontend AutoGPT Platform - Front end label Oct 23, 2024
@github-actions github-actions bot added size/l and removed size/m labels Oct 23, 2024
Copy link
Member

@ntindle ntindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some changes in #8403 that will likely impact this

validate that the API key works via .env as I wouldn't expect that to work with credits and what not based on current system design

autogpt_platform/backend/.env.example Show resolved Hide resolved
@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Oct 24, 2024
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot removed platform/frontend AutoGPT Platform - Front end conflicts Automatically applied to PRs with merge conflicts labels Oct 24, 2024
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@@ -180,3 +190,82 @@ def run(self, input_data: Input, **kwargs) -> BlockOutput:
yield "condition", weather_data["weather"][0]["description"]
else:
raise RuntimeError(f"Expected keys not found in response: {weather_data}")


class FactCheckerBlock(Block, GetRequest):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to /jina folder and reuse the _auth.py there

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do :)

Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Oct 31, 2024
@majdyz majdyz removed their request for review November 5, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts Automatically applied to PRs with merge conflicts platform/backend AutoGPT Platform - Back end platform/blocks size/l
Projects
Status: 🚧 Needs work
Development

Successfully merging this pull request may close these issues.

3 participants