You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here are some key observations to aid the review process:
⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪
🧪 PR contains tests
🔒 Security concerns
SQL Injection: The database URL is parsed and reconstructed manually in _extract_schema_from_url function. While urlparse is used, the function should validate/sanitize the schema parameter before using it in SQL queries to prevent potential SQL injection.
⚡ Recommended focus areas for review
Error Handling The execute_graph function catches all exceptions but only logs them. Consider whether failed jobs should be retried or if errors should trigger notifications.
Data Validation No validation is performed on the cron expression before adding jobs. Invalid cron expressions could cause scheduling failures.
Type Safety The type checking for inputEntries could be more robust. Consider adding more specific type guards.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The execution schedule is stored in the database, but the execution history is not tracked, so when the server dies, it forgot its past executions.
The UI for the agent scheduler will soon be available: #8634.
Changes 🏗️
get_execution_schedules
API.next_run_time
information.Checklist 📋
For code changes:
Example test plan
For configuration changes:
.env.example
is updated or already compatible with my changesdocker-compose.yml
is updated or already compatible with my changesExamples of configuration changes