Add support for JRE provisioning: Jre tar.gz unpack - extract IFilePermissionsProvider #2051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmissionsProvider
| @@ -56,13 +59,15 @@ public void TarGzUnpacking_Success() | |||
| using var archive = new MemoryStream(Convert.FromBase64String(sampleTarGzFile)); | |||
| using var unzipped = new MemoryStream(); | |||
| fileWrapper.Create($"""{baseDirectory}\Main\Sub2\Sample.txt""").Returns(unzipped); | |||
| filePermissionsWrapper.When(x => x.Copy(Arg.Any<TarEntry>(), Arg.Any<string>())).Throw(new Exception("Sample exception message")); | |||
There was a problem hiding this comment.
The only relevant change as far as tests are concerned.
There was a problem hiding this comment.
Could you please update the test name to reflect the flow?
Unpacking -> Success, Copy -> fail
Otherwise, the new behavior seems to be a different test. Maybe it should be :)
There was a problem hiding this comment.
I will rename it, as I don't think it is worth it to make another test just for this one debug log message.
src/SonarScanner.MSBuild.PreProcessor/JreCaching/FilePermissionsWrapper.cs
Show resolved
Hide resolved
| using Microsoft.VisualStudio.TestTools.UnitTesting; | ||
| using NSubstitute; | ||
| using NSubstitute.ExceptionExtensions; |
costin-zaharia-sonarsource
approved these changes
Jul 12, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2048