Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gems and ruby to 3.2.2 – Fixes #1290 #1289

Merged
merged 3 commits into from
Aug 21, 2023
Merged

Update gems and ruby to 3.2.2 – Fixes #1290 #1289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49eace9
Update gems and ruby to 3.2.2
Bramjetten Aug 21, 2023
eeb87bc
Merge branch 'main' into fixtestsuite
Bramjetten Aug 21, 2023
628169a
Require minitest::unit and fix chromedriver issue
Bramjetten Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
ruby-version: ['3.1']
ruby-version: ['3.2']

services:
postgres:
Expand Down
4 changes: 4 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ test/dummy/db/*.sqlite3
test/dummy/log/*.log
test/dummy/tmp/
test/dummy/.sass-cache
test/dummy/public/assets/
.DS_Store
test/dummy/public/uploads/*
test/dummy/app/assets/fonts/
Expand All @@ -23,3 +24,6 @@ test/dummy/storage/*

.nova
.ruby-version

# Ignore auto-generated Spina Tailwind CSS configuration
/app/assets/config/spina/tailwind.config.js
3 changes: 1 addition & 2 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ group :test do

# System tests
gem "capybara"
gem "selenium-webdriver", "~> 4.9.0"
gem "webdrivers"
gem "selenium-webdriver", "~> 4.11.0"

gem "pry-rails"
gem "mocha"
Expand Down
11 changes: 3 additions & 8 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ GEM
ffi (~> 1.12)
ruby2_keywords (0.0.5)
rubyzip (2.3.2)
selenium-webdriver (4.9.0)
selenium-webdriver (4.11.0)
rexml (~> 3.2, >= 3.2.5)
rubyzip (>= 1.2.2, < 3.0)
websocket (~> 1.0)
Expand Down Expand Up @@ -278,10 +278,6 @@ GEM
activesupport (>= 5.2.0, < 8.0)
concurrent-ruby (~> 1.0)
method_source (~> 1.0)
webdrivers (5.3.1)
nokogiri (~> 1.6)
rubyzip (>= 1.3.0)
selenium-webdriver (~> 4.0, < 4.11)
websocket (1.2.9)
websocket-driver (0.7.5)
websocket-extensions (>= 0.1.0)
Expand All @@ -303,10 +299,9 @@ DEPENDENCIES
pry-rails
puma
rails-controller-testing
selenium-webdriver (~> 4.9.0)
selenium-webdriver (~> 4.11.0)
simplecov
spina!
webdrivers

BUNDLED WITH
2.3.10
2.4.18
1 change: 0 additions & 1 deletion test/application_system_test_case.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
require "test_helper"

class ApplicationSystemTestCase < ActionDispatch::SystemTestCase
Webdrivers::Chromedriver.required_version = "114.0.5735.90"
driven_by :selenium, using: :headless_chrome, screen_size: [1400, 1400]

setup do
Expand Down
1 change: 1 addition & 0 deletions test/test_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

require File.expand_path("../dummy/config/environment.rb", __FILE__)
require "rails/test_help"
require "minitest/unit"
require "minitest/reporters"
require "factory_bot"
require "mocha/minitest"
Expand Down
Loading