Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview website button - Fixes #1327 #1331

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

Bramjetten
Copy link
Contributor

CleanShot 2023-10-19 at 14 32 52@2x

@Bramjetten Bramjetten merged commit dfa0393 into SpinaCMS:main Oct 19, 2023
1 check passed
@Bramjetten Bramjetten deleted the previewwebsitebutton branch October 19, 2023 12:37
@sedubois
Copy link
Contributor

@Bramjetten could this preview feature be made available in the demo site?

https://spinacms-demo.herokuapp.com/admin/pages

Screenshot 2024-01-27 at 10 21 18

@sedubois
Copy link
Contributor

Also I think I misunderstood the feature, the name "preview" to me seemed to indicate that a draft can be previewed before publishing, but the link instead points to the application's root path which would render the published version I guess, not a draft.

@Bramjetten
Copy link
Contributor Author

Also I think I misunderstood the feature, the name "preview" to me seemed to indicate that a draft can be previewed before publishing, but the link instead points to the application's root path which would render the published version I guess, not a draft.

That's a good feature request. It makes sense to preview the current draft and should be easy enough to implement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants