Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sdk and test / verify projects to net8; unquote itself stays at netstandard2.0 #166

Merged
merged 4 commits into from
Dec 29, 2023

Conversation

stephen-swensen
Copy link
Contributor

@stephen-swensen stephen-swensen commented Dec 29, 2023

See #167

@stephen-swensen stephen-swensen added this to the 7.0.0 milestone Dec 29, 2023
@stephen-swensen stephen-swensen merged commit 192067c into master Dec 29, 2023
@stephen-swensen stephen-swensen deleted the net8 branch December 29, 2023 22:21
@bartelink
Copy link
Contributor

bartelink commented Apr 5, 2024

TL;DR could the FSharp.Core dep be lowered back down to 6.0.7 (or lower) please? @stephen-swensen


Updating the FSharp.Core causes a lot of run on implications
For example: fsprojects/Argu#237
This is not dissimilar to how FsHttp also did a similar update: fsprojects/FsHttp#183
FSharp.AWS.DynamoDB and other low level components depend on unquote
TaskSeq follows this approach too: fsprojects/FSharp.Control.TaskSeq#123

My personal stuff depends on 6.0.7 for two reasons

  • there's a bug fixed in there where the process can be torn down without a stacktrace under Async.Parallel.
  • I used Async.Parallel in an internal implementation

NOTE: I do get that there's no actual reason why some old thing from 10 yars ago can't 'Just' update it's FSharp.Core from 4.3.2 to 8.0.100 without expecting it to just work, but that's not the point - it should simply depend on the lowest version possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade sdk and test / verify projects to net8; unquote itself stays at netstandard2.0
2 participants