Update packaging to the pip install method #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o#44) (non contributors cannot be assigned to issues)
… running. (TamtamHero#46) Authored-by: Nina Alexandra Klama <[email protected]>
* removing binary blobs from the project. we now fetch the ectool from the gitlab artifacts and confirm the checksum. * remove bin references from README.md * extracting $TEMP_FOLDER from installEctool
…e description (TamtamHero#52) * Review README spelling/grammar * Fix "FrameWork" capitalization in service
…ontroller and SocketController diversity. 2 (Repost of TamtamHero#50) (TamtamHero#58) * separating `FanController` into different subclasses to allow `HardwareController` and `SocketController` diversity * adding the new arguments into the README.md * fixing an indentation error causing `--strategy <strategy>` not to work (the simple `<strategy>` still worked)
…ket method instead of manual closing, as well as updating error detection pattern (TamtamHero#64)
* forcing utf-8 encoding for socket messages and usage of stopServerSocket method instead of manual closing, as well as updating error detection pattern * README.md documentation update * change log format on fatal crash * fix badges links * adding windows platform badge and issue template * fix `:` instead of `=` * disabling part of the README.md while waiting for merge
* forcing utf-8 encoding for socket messages and usage of stopServerSocket method instead of manual closing, as well as updating error detection pattern * README.md documentation update * change log format on fatal crash * fix badges links * adding windows platform badge and issue template * fix `:` instead of `=` * first part of the command argument refactoring. the old argument format is deprecated but still usable. improved feedback when executing commands. TamtamHero#31 * trim blank lines in README.md
* add configuration for no battery mode in hardware controller * fix wrong line getting noBatteryMode * dynamically fetching battery sensor on init/reload * add --no-battery flag for install * update readme with --no-battery flag * rework no battery config to come from service args * change sensors to be ectool specific - reword the argument to be more clear about battery sensors - move `noBatteryMode` and `nonBatterySensors` to EctoolHardwareController - update `getNonBatterySensors` to be able to handle more than one sensor - update installer and readme accordingly * update grep command for checking existing `--no-battery-sensors` * combine getTemperature functions to one * add documentation for run option `--no-battery-sensors` * rename variable `NO_BATTERY` to `NO_BATTERY_SENSOR` * update the installer to use existing placeholder format * rename noBatterySensorMode variables and functions for clarity * rename placeholder to `NO_BATTERY_SENSOR_OPTION` for clarity * update comments in installer to reflect new argument name
typo "tempurature" => "temperature"
typo "tempurature" => "temperature"
* add doc folder * update nix link * add toc * add link * add missin # * add doc * fix link * add new line under titles
* Add option to print current speed percentage * Update README.md * Update commands.md * Add print choice descriptions to help text
* Additional context to command returns (current strategy and new behaviour) * adding "strategy in use" context to reset command
> multi file script > pip installation
> fixing the module name ("src" => "fw_fanctrl")
* JSON output format (`--output-format` NATURAL, JSON) * Add normalized output format to service runtime * Add an "all" print option and set it to default. * Add active status print
# Conflicts: # fanctrl.py
…case standard (except for dtos as it affects the JSON output)
> proper project declaration > multi file script > pip installation > refactor .gitignore > Changing variable and function names to comply with python's snake-case standard (except for dtos as it affects the JSON output) > Adding .editorconfig to ensure IDE consistency
leopoldhub
reviewed
Feb 1, 2025
|
Everything done |
|
I merged #100 into this pr |
|
Thanks a lot ^^ Have a nice day! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.